Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stepper performance bug - Take II #97451

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Fix Stepper performance bug - Take II #97451

wants to merge 6 commits into from
+95 −80

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Dec 13, 2024 •
edited
Loading

Depends on #97480

This PR is the exact replica of the original PR (#97354), but it now depends on #97480.

In another instance of tree-shaking breaking down, Stepper was pulling a ton of JS and CSS that it never runs since #67887.

Fixes #97337

Proposed Changes

This moves the setupErrorLogger function from a big file full of imports into its own file to help tree shaking.

Why are these changes being made?

To make Stepper faster.

Testing Instructions

  1. Go to /setup/onboarding.
  2. Make sure dashicons.css is not loaded.
  3. Go to /me/purchases. Make sure the table headings (Site, Product, Status, Payment method) are well aligned.
  4. /start/domains/use-your-domain.
  5. Make sure the form is centered.

@alshakero alshakero requested a review from a team as a code owner December 13, 2024 13:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-127688
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-127688&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-127688&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented Dec 13, 2024 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~95956 bytes added 📈 [gzipped])

name                   parsed_size            gzip_size
entry-stepper            -866590 B  (-37.9%)  -195271 B  (-32.1%)
entry-main                +11490 B   (+0.5%)    +8080 B   (+1.4%)
entry-login                +9866 B   (+0.5%)    +8886 B   (+1.5%)
entry-domains-landing      +7461 B   (+1.1%)    +2373 B   (+1.2%)
entry-browsehappy          +7335 B   (+3.5%)    +2031 B   (+3.3%)
entry-subscriptions        +6615 B   (+0.4%)    +2875 B   (+0.6%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~401314 bytes added 📈 [gzipped])

name                                parsed_size             gzip_size
link-in-bio-tld-flow                  +340235 B   (+19.0%)  +106242 B   (+20.2%)
update-design-flow                    +309298 B   (+25.8%)   +89177 B   (+26.3%)
write-flow                            +287314 B   (+37.4%)   +90605 B   (+38.2%)
build-flow                            +287314 B   (+37.4%)   +90620 B   (+38.3%)
import-hosted-site-flow               +262012 B   (+31.4%)   +83047 B   (+33.3%)
copy-site-flow                        +257114 B   (+38.6%)   +82880 B   (+40.5%)
transferring-hosted-site-flow         +167311 B  (+163.3%)   +53891 B  (+157.5%)
plugin-bundle-flow                    +164882 B   (+86.2%)   +52826 B   (+81.0%)
entrepreneur-flow                     +164345 B  (+136.5%)   +46656 B  (+169.4%)
newsletter-post-setup-flow            +160920 B  (+137.4%)   +52338 B  (+131.3%)
link-in-bio-post-setup-flow           +160920 B  (+137.7%)   +52338 B  (+131.7%)
stepper-user-step                     +156494 B  (+160.3%)   +49453 B  (+159.3%)
domain-user-transfer-flow             +134014 B   (+57.8%)   +42614 B   (+91.0%)
assembler-first-flow                  +131661 B  (+125.6%)   +35708 B  (+175.6%)
readymade-template-flow               +131051 B   (+95.3%)   +34123 B  (+107.9%)
with-theme-assembler-flow             +121830 B  (+127.8%)   +32385 B  (+186.3%)
site-setup-wg                          +52204 B   (+49.4%)   +10398 B   (+48.9%)
site-setup-flow                        +52204 B   (+50.2%)   +10398 B   (+50.6%)
ai-assembler-flow                      +43265 B   (+52.6%)    +7444 B   (+50.7%)
site-migration-flow                    +40335 B   (+47.5%)    +6793 B   (+43.4%)
hosted-site-migration-flow             +40335 B   (+47.3%)    +6793 B   (+42.7%)
import-flow                            +32012 B   (+49.6%)    +3931 B   (+40.9%)
migration-flow                         +30736 B   (+39.8%)    +3724 B   (+26.4%)
migration-signup                       +28888 B   (+48.2%)    +3119 B   (+38.8%)
onboarding-flow                        +24623 B   (+34.2%)    +1191 B   (+10.3%)
tailored-ecommerce-flow                +23377 B   (+40.2%)     +908 B   (+13.0%)
update-options-flow                    +22267 B   (+41.0%)     +778 B   (+13.0%)
trial-wooexpress-flow                  +22267 B   (+38.7%)     +784 B   (+10.8%)
free-post-setup-flow                   +22267 B   (+41.3%)     +767 B   (+13.0%)
design-first-flow                      +14496 B   (+56.4%)    +3360 B   (+56.1%)
signup                                 +14492 B    (+5.2%)     +414 B    (+0.6%)
start-writing-flow                     +14280 B   (+57.0%)    +3351 B   (+56.8%)
hundred-year-plan                      +13094 B   (+35.5%)    +3547 B   (+32.4%)
newsletter-flow                        +12610 B   (+60.4%)    +3307 B   (+59.6%)
hundred-year-domain                    +12006 B   (+23.7%)    +3574 B   (+23.6%)
new-hosted-site-flow                    +1969 B   (+20.7%)     +112 B    (+4.0%)
connect-domain                          +1878 B    (+7.2%)     +253 B    (+3.6%)
reblogging-flow                         +1462 B   (+24.7%)      +80 B    (+4.3%)
new-hosted-site-flow-user-included      +1223 B   (+19.3%)      +69 B    (+3.3%)
google-transfer                         +1007 B   (+23.9%)      +78 B    (+5.7%)
domain-transfer                         +1007 B   (+25.5%)      +77 B    (+5.9%)
a8c-for-agencies-client                  +776 B    (+0.1%)     +409 B    (+0.1%)
site-performance                         +703 B    (+0.0%)     -773 B    (-0.2%)
staging-site                             +682 B    (+0.0%)     -435 B    (-0.1%)
site-marketing                           +661 B    (+0.0%)     +632 B    (+0.1%)
jetpack-cloud-plugin-management          +590 B    (+0.0%)      -69 B    (-0.0%)
site-settings                            +539 B    (+0.0%)     +380 B    (+0.1%)
site-monitoring                          +536 B    (+0.0%)      -32 B    (-0.0%)
site-logs                                +535 B    (+0.0%)      +54 B    (+0.0%)
site-tools                               +516 B    (+0.0%)     +514 B    (+0.1%)
plugins                                  +406 B    (+0.0%)     -452 B    (-0.0%)
plans                                    -349 B    (-0.0%)    -1468 B    (-0.4%)
hosting-features                         +312 B    (+0.0%)     +441 B    (+0.1%)
migrate                                  -279 B    (-0.1%)     -393 B    (-0.4%)
themes                                   +276 B    (+0.0%)     +724 B    (+0.2%)
jetpack-search                           -263 B    (-0.0%)     -652 B    (-0.4%)
hosting                                  +255 B    (+0.0%)     -356 B    (-0.1%)
sites-dashboard                          +214 B    (+0.0%)     +411 B    (+0.1%)
activity                                 -204 B    (-0.0%)     -860 B    (-0.4%)
customize                                -199 B    (-0.1%)     -502 B    (-0.5%)
jetpack-app                              -198 B    (-0.0%)     -810 B    (-0.6%)
preview                                  -191 B    (-0.1%)      -35 B    (-0.0%)
site-overview                            +190 B    (+0.0%)     -268 B    (-0.1%)
jetpack-connect                          +186 B    (+0.0%)     +714 B    (+0.2%)
jetpack-cloud-settings                   -180 B    (-0.0%)    +1013 B    (+0.5%)
settings-performance                     +178 B    (+0.0%)     +277 B    (+0.2%)
scan                                     -177 B    (-0.0%)    -1254 B    (-0.5%)
jetpack-cloud-agency-sites-v2            -173 B    (-0.0%)     -492 B    (-0.1%)
github-deployments                       +173 B    (+0.0%)     +489 B    (+0.1%)
people                                   +172 B    (+0.0%)     +674 B    (+0.3%)
settings-security                        +169 B    (+0.0%)     +262 B    (+0.2%)
import                                   +160 B    (+0.0%)    -1366 B    (-0.6%)
gutenberg-editor                         -160 B    (-0.0%)     -555 B    (-0.3%)
marketing                                -157 B    (-0.0%)     +430 B    (+0.2%)
settings-reading                         -153 B    (-0.0%)     +311 B    (+0.2%)
domains                                  +143 B    (+0.0%)     +138 B    (+0.0%)
settings-podcast                         +139 B    (+0.0%)     +350 B    (+0.2%)
settings                                 +134 B    (+0.0%)     +746 B    (+0.2%)
woocommerce                              +133 B    (+0.0%)      +27 B    (+0.0%)
comments                                 +128 B    (+0.0%)      +27 B    (+0.0%)
reader                                   +126 B    (+0.0%)     +620 B    (+0.1%)
a8c-for-agencies-team                    +126 B    (+0.0%)     +314 B    (+0.1%)
a8c-for-agencies-referrals               +126 B    (+0.0%)     +579 B    (+0.2%)
a8c-for-agencies-overview                +126 B    (+0.0%)     +521 B    (+0.2%)
a8c-for-agencies-migrations              +126 B    (+0.0%)     +579 B    (+0.2%)
marketplace                              +120 B    (+0.0%)      +74 B    (+0.0%)
subscribers                              +116 B    (+0.0%)     +542 B    (+0.2%)
stats                                    +111 B    (+0.0%)     -474 B    (-0.1%)
devdocs                                  +101 B    (+0.1%)      +25 B    (+0.0%)
promote-post-i2                          +100 B    (+0.0%)     +892 B    (+0.4%)
patterns                                 +100 B    (+0.0%)     +635 B    (+0.1%)
a8c-for-agencies-sites                    +99 B    (+0.0%)     +124 B    (+0.0%)
purchase-product                          -96 B    (-0.1%)      +21 B    (+0.0%)
a8c-for-agencies-partner-directory        -96 B    (-0.0%)      -23 B    (-0.0%)
settings-jetpack                          -95 B    (-0.0%)     -586 B    (-0.4%)
a8c-for-agencies-settings                 +93 B    (+0.0%)      -10 B    (-0.0%)
a8c-for-agencies-plugins                  +93 B    (+0.1%)      -10 B    (-0.0%)
a8c-for-agencies-landing                  +93 B    (+0.1%)       -8 B    (-0.0%)
a8c-for-agencies-agency-tier              +93 B    (+0.0%)      -12 B    (-0.0%)
woocommerce-installation                  -87 B    (-0.0%)     -211 B    (-0.2%)
switch-site                               +86 B    (+0.0%)       +4 B    (+0.0%)
site-blocks                               -83 B    (-0.0%)       -7 B    (-0.0%)
performance-profiler                      -83 B    (-0.0%)      -22 B    (-0.0%)
notification-settings                     -83 B    (-0.0%)       -4 B    (-0.0%)
media                                     -83 B    (-0.0%)       -9 B    (-0.0%)
me                                        -83 B    (-0.0%)       -6 B    (-0.0%)
jetpack-cloud-features-comparison         -83 B    (-0.0%)      -63 B    (-0.0%)
help                                      -83 B    (-0.0%)       -6 B    (-0.0%)
google-my-business                        -83 B    (-0.0%)       -9 B    (-0.0%)
export                                    -83 B    (-0.0%)       -9 B    (-0.0%)
email                                     -83 B    (-0.0%)      +68 B    (+0.0%)
concierge                                 -83 B    (-0.0%)       -9 B    (-0.0%)
add-ons                                   -83 B    (-0.0%)       -9 B    (-0.0%)
account-close                             -83 B    (-0.0%)       -6 B    (-0.0%)
a8c-for-agencies                          -83 B    (-0.1%)      -22 B    (-0.1%)
site-purchases                            +74 B    (+0.0%)    -1072 B    (-0.2%)
earn                                      -54 B    (-0.0%)     -525 B    (-0.2%)
pages                                     +45 B    (+0.0%)     +163 B    (+0.1%)
checkout                                  +43 B    (+0.0%)     -349 B    (-0.1%)
jetpack-cloud-partner-portal              -40 B    (-0.0%)      -80 B    (-0.0%)
backup                                    -37 B    (-0.0%)     -450 B    (-0.1%)
posts                                     +31 B    (+0.0%)     -276 B    (-0.1%)
settings-discussion                       +29 B    (+0.0%)     +337 B    (+0.3%)
posts-custom                              -29 B    (-0.0%)     -306 B    (-0.1%)
theme                                     +26 B    (+0.0%)     -245 B    (-0.1%)
security                                  -23 B    (-0.0%)       -2 B    (-0.0%)
purchases                                 +23 B    (+0.0%)     -615 B    (-0.1%)
home                                      -23 B    (-0.0%)     +474 B    (+0.1%)
settings-writing                          +16 B    (+0.0%)     +219 B    (+0.1%)
settings-newsletter                       +16 B    (+0.0%)     +225 B    (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~215729 bytes added 📈 [gzipped])

name                                                                              parsed_size             gzip_size
async-load-automattic-help-center-v-2                                               +821947 B      (new)  +250496 B      (new)
async-load-calypso-my-sites-checkout-modal                                          +284664 B   (+23.6%)   +93743 B   (+27.6%)
async-load-signup-steps-theme-selection                                             +115605 B   (+60.2%)   +37582 B   (+65.0%)
async-load-signup-steps-clone-point                                                  +96682 B   (+55.7%)   +30577 B   (+69.1%)
async-load-signup-steps-site-picker                                                  +94378 B   (+63.7%)   +30994 B   (+67.2%)
async-load-signup-steps-difm-site-picker                                             +94378 B   (+63.8%)   +31027 B   (+67.1%)
async-load-signup-steps-domains                                                      +93989 B   (+17.0%)   +30654 B   (+18.6%)
async-load-signup-steps-website-content                                              +84387 B   (+73.9%)   +26788 B   (+69.9%)
async-load-signup-steps-courses                                                      +80275 B  (+238.1%)   +25450 B  (+225.2%)
async-load-signup-steps-website-content-section-types                                +60918 B   (+85.2%)   +19439 B   (+84.4%)
async-load-calypso-blocks-jitm                                                       +59473 B  (+421.0%)   +18940 B  (+422.3%)
async-load-signup-steps-user                                                         +57072 B   (+34.1%)   +20441 B   (+42.6%)
async-load-signup-steps-page-picker                                                  +48050 B   (+13.0%)   +15906 B   (+13.7%)
async-load-signup-steps-p2-complete-profile                                          +40806 B   (+38.0%)   +13931 B   (+41.6%)
async-load-signup-steps-design-picker                                                +26041 B   (+49.1%)    +8200 B   (+46.8%)
async-load-signup-steps-woocommerce-install-step-business-info                       +25443 B   (+28.7%)    +8041 B   (+28.2%)
async-load-purchase-modal-wrapper                                                    +25422 B    (+6.9%)    +9229 B    (+8.1%)
async-load-signup-steps-woocommerce-install-step-store-address                       +25353 B   (+38.1%)    +7951 B   (+36.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...     +25226 B    (+7.1%)    +8588 B    (+7.8%)
async-load-signup-steps-creds-permission                                             +23275 B   (+44.9%)    +6761 B   (+38.5%)
async-load-signup-steps-woocommerce-install-transfer                                 +23210 B   (+72.3%)    +7350 B   (+70.0%)
async-load-signup-steps-woocommerce-install-confirm                                  +23028 B   (+41.7%)    +7366 B   (+41.1%)
async-load-signup-steps-store-features                                               +22896 B   (+51.9%)    +7155 B   (+52.0%)
async-load-signup-steps-p2-join-workspace                                            +22823 B   (+73.1%)    +7256 B   (+71.1%)
async-load-signup-steps-hosting-decider                                              +22814 B  (+101.2%)    +7276 B   (+93.9%)
async-load-signup-steps-p2-details                                                   +22695 B   (+90.1%)    +7272 B   (+85.6%)
async-load-signup-steps-site                                                         +22629 B   (+52.2%)    +7232 B   (+54.5%)
async-load-signup-steps-p2-site                                                      +22629 B   (+43.0%)    +7224 B   (+45.6%)
async-load-signup-steps-rewind-form-creds                                            +21593 B   (+30.7%)    +6294 B   (+27.4%)
async-load-signup-steps-creds-confirm                                                +21593 B   (+41.6%)    +6277 B   (+35.8%)
async-load-signup-steps-clone-credentials                                            +21593 B   (+29.2%)    +6289 B   (+26.5%)
async-load-signup-steps-new-or-existing-site                                         +21409 B   (+46.3%)    +6658 B   (+43.8%)
async-load-signup-steps-emails                                                       +21279 B   (+34.1%)    +6614 B   (+32.6%)
async-load-signup-steps-intent                                                       +21026 B   (+53.0%)    +6575 B   (+52.4%)
async-load-signup-steps-initial-intent                                               +20942 B   (+26.3%)    +6706 B   (+25.7%)
async-load-signup-steps-test-step                                                    +20880 B   (+97.4%)    +6521 B   (+90.7%)
async-load-signup-steps-starting-point                                               +20880 B   (+56.8%)    +6521 B   (+56.1%)
async-load-signup-steps-social-profiles                                              +20880 B   (+75.1%)    +6521 B   (+71.8%)
async-load-signup-steps-site-or-domain                                               +20880 B   (+50.7%)    +6521 B   (+51.6%)
async-load-signup-steps-site-options                                                 +20880 B   (+49.0%)    +6521 B   (+49.1%)
async-load-signup-steps-rewind-were-backing                                          +20880 B   (+90.9%)    +6521 B   (+84.3%)
async-load-signup-steps-reader-landing                                               +20880 B   (+81.1%)    +6521 B   (+78.5%)
async-load-signup-steps-p2-confirm-email                                             +20880 B   (+77.1%)    +6521 B   (+71.8%)
async-load-signup-steps-clone-start                                                  +20880 B   (+73.5%)    +6521 B   (+69.6%)
async-load-signup-steps-clone-destination                                            +20880 B   (+62.7%)    +6521 B   (+62.6%)
async-load-signup-steps-clone-cloning                                                +20880 B   (+74.7%)    +6521 B   (+71.0%)
async-load-calypso-signup-step-wrapper                                               +20880 B  (+133.6%)    +6521 B  (+124.2%)
async-load-signup-steps-clone-ready                                                  +20700 B   (+37.7%)    +6239 B   (+35.9%)
async-load-signup-steps-woocommerce-install                                          +20341 B  (+679.8%)    +6335 B  (+596.0%)
async-load-calypso-blocks-jitm-templates-modal                                       +20341 B   (+77.9%)    +6335 B   (+69.5%)
async-load-automattic-onboarding-src-step-container                                  +20341 B  (+209.8%)    +6335 B  (+195.2%)
async-load-signup-steps-plans-theme-preselected                                      +18562 B    (+4.8%)    +5303 B    (+4.2%)
async-load-signup-steps-plans                                                        +18562 B    (+4.8%)    +5303 B    (+4.2%)
async-load-calypso-blocks-cookie-banner                                              +15836 B      (new)    +5327 B      (new)
async-load-automattic-help-center                                                    +11952 B    (+1.8%)     +292 B    (+0.1%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                               +5209 B   (+11.2%)    +1939 B   (+11.8%)
async-load-calypso-blocks-jitm-templates-notice                                       +5209 B   (+11.1%)    +1939 B   (+11.7%)
async-load-calypso-blocks-jitm-templates-default                                      +5209 B   (+11.2%)    +1940 B   (+11.7%)
async-load-calypso-components-global-notices                                          +2911 B   (+60.3%)    +1072 B   (+63.4%)
async-load-signup-steps-woocommerce-install-hooks-use-site-settings                   +2690 B   (+65.1%)     +814 B   (+50.7%)
async-load-automattic-search                                                          +2685 B    (+8.9%)     +928 B    (+8.9%)
async-load-site-build-showcase                                                        +2231 B   (+92.3%)     +906 B   (+82.7%)
async-load-automattic-design-preview                                                  +2125 B    (+0.1%)     +998 B    (+0.2%)
async-load-signup-steps-woocommerce-install-components-support-card                   +1943 B  (+145.7%)     +787 B  (+108.1%)
async-load-calypso-state-lib-automated-transfer-middleware                             +996 B    (+4.9%)     +942 B   (+15.4%)
async-load-design                                                                      -607 B    (-0.0%)     +133 B    (+0.0%)
async-load-calypso-components-web-preview-component                                    +497 B    (+0.1%)     -444 B    (-0.3%)
async-load-calypso-blocks-support-article-dialog-dialog                                -279 B    (-0.3%)     -562 B    (-1.9%)
async-load-publish                                                                     +246 B    (+2.6%)      +41 B    (+1.2%)
async-load-design-blocks                                                               +225 B    (+0.0%)     +716 B    (+0.1%)
async-load-calypso-my-sites-current-site-notice                                        +222 B    (+0.4%)      +13 B    (+0.1%)
async-load-comment-block-editor                                                        +196 B    (+0.0%)     +656 B    (+0.1%)
async-load-calypso-layout-popup-search                                                 -196 B    (-1.2%)     -392 B    (-7.6%)
async-load-automattic-global-styles-src-components-global-styles-variations            +196 B    (+0.0%)     +659 B    (+0.1%)
async-load-calypso-reader-sidebar                                                      +162 B    (+0.2%)       +7 B    (+0.0%)
async-load-calypso-my-sites-stats-summary                                              +162 B    (+0.3%)       +8 B    (+0.1%)
async-load-calypso-blocks-product-purchase-features-list                               -116 B    (-0.2%)     -363 B    (-2.9%)
async-load-calypso-layout-masterbar-drafts-popover                                     +113 B    (+0.4%)     +619 B    (+6.4%)
async-load-calypso-my-sites-stats-stats-post-detail                                    -108 B    (-0.3%)      -28 B    (-0.3%)
async-load-calypso-my-sites-site-settings-seo-settings-form                            -108 B    (-0.0%)      -32 B    (-0.0%)
async-load-calypso-blocks-support-article-dialog                                       -108 B    (-5.6%)      -55 B    (-6.3%)
async-load-design-wordpress-components-gallery                                         +103 B    (+0.0%)     -189 B    (-0.1%)
async-load-calypso-layout-command-palette                                               +86 B    (+0.0%)       +4 B    (+0.0%)
async-load-calypso-components-sites-popover                                             -83 B    (-0.1%)       -9 B    (-0.0%)
async-load-calypso-components-jetpack-portal-nav                                        -83 B    (-0.2%)      -12 B    (-0.1%)
async-load-calypso-lib-store-sandbox-helper                                             +73 B    (+0.2%)       +6 B    (+0.1%)
async-load-calypso-jetpack-cloud-sections-sidebar-navigation-manage-selected-...        +73 B    (+0.1%)       +6 B    (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                                         +73 B    (+0.0%)      -97 B    (-0.0%)
async-load-design-playground                                                            +16 B    (+0.0%)     +239 B    (+0.1%)
async-load-store-app-store-stats-listview                                               +13 B    (+0.0%)      -16 B    (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@alshakero alshakero force-pushed the revert-97429-revert-97354-fix/stepper-perf-bug branch from a18f740 to 55b6a6c Compare December 13, 2024 20:59
@alshakero alshakero changed the base branch from trunk to fix/help-center-dupe-css December 13, 2024 21:16
@alshakero alshakero mentioned this pull request Dec 13, 2024
Merged
@alshakero alshakero changed the title Revert "Revert "Fix Stepper performance bug"" Fix Stepper performance bug - Take II Dec 13, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 13, 2024 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-97429-revert-97354-fix/stepper-perf-bug on your sandbox.

leonardost
leonardost approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@leonardost leonardost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked /me/purchases and /start/domains/use-your-domain that were mentioned in p1734034864133699-slack-C0BNMNMNG and they look correct 🙂 thanks for investigating this weird issue!

Base automatically changed from fix/help-center-dupe-css to trunk December 16, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardost leonardost leonardost approved these changes

Assignees
No one assigned
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stepper: Improve performances
3 participants
@alshakero @matticbot @leonardost